From 91bcfcc9583a61158f7f69f52ff3575eb432067f Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Wed, 11 Dec 2013 09:49:07 -0500 Subject: [PATCH 01/14] intel-hda: fix position buffer Message-id: <1386755347-9800-2-git-send-email-kraxel@redhat.com> Patchwork-id: 56156 O-Subject: [RHEL-7 qemu-kvm PATCH 1/1] intel-hda: fix position buffer Bugzilla: 947785 RH-Acked-by: Stefan Hajnoczi RH-Acked-by: Miroslav Rezanina RH-Acked-by: Orit Wasserman Fix position buffer updates to use the correct stream offset. Without this patch both IN (record) and OUT (playback) streams will update the IN buffer positions. The linux kernel notices and complains: hda-intel: Invalid position buffer, using LPIB read method instead. The bug may also lead to glitches when recording and playing at the same time: https://bugzilla.redhat.com/show_bug.cgi?id=947785 Cc: qemu-stable@nongnu.org Signed-off-by: Gerd Hoffmann (cherry picked from commit d58ce68a454e5ae9cbde0308def379e272f13b10) --- hw/audio/intel-hda.c | 1 + 1 file changed, 1 insertion(+) Signed-off-by: Miroslav Rezanina --- hw/audio/intel-hda.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index e747342..cc948de 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda.c @@ -439,6 +439,7 @@ static bool intel_hda_xfer(HDACodecDevice *dev, uint32_t stnr, bool output, } } if (d->dp_lbase & 0x01) { + s = st - d->st; addr = intel_hda_addr(d->dp_lbase & ~0x01, d->dp_ubase); stl_le_pci_dma(&d->pci, addr + 8*s, st->lpib); } -- 1.8.3.1