From c20afdaa429580421341c2ee408c50db3296c7fc Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Tue, 1 Nov 2011 15:40:32 +0100 Subject: [PATCH 1/3] hda: do not mix output and input streams, RHBZ #740493 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit RH-Author: Gerd Hoffmann Message-id: <1320162033-7365-2-git-send-email-kraxel@redhat.com> Patchwork-id: 34799 O-Subject: [RHEL-6.2 qemu-kvm PATCH 1/2] hda: do not mix output and input streams, RHBZ #740493 Bugzilla: 740493 RH-Acked-by: Kevin Wolf RH-Acked-by: Markus Armbruster From: Marc-André Lureau Windows 7 may use the same stream number for input and output. That will result in lot of garbage on playback. The hardcoded value of 4 needs to be in sync with GCAP streams description and IN/OUT registers. Signed-off-by: Marc-Andr? Lureau Signed-off-by: malc (cherry picked from commit 36ac4ad3d054a7b4962a6393630a73591cfa9558) Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) Signed-off-by: Michal Novotny --- hw/intel-hda.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/intel-hda.c b/hw/intel-hda.c index 72a4bec..2f5669a 100644 --- a/hw/intel-hda.c +++ b/hw/intel-hda.c @@ -391,14 +391,15 @@ static bool intel_hda_xfer(HDACodecDevice *dev, uint32_t stnr, bool output, { HDACodecBus *bus = DO_UPCAST(HDACodecBus, qbus, dev->qdev.parent_bus); IntelHDAState *d = container_of(bus, IntelHDAState, codecs); - IntelHDAStream *st = NULL; target_phys_addr_t addr; uint32_t s, copy, left; + IntelHDAStream *st; bool irq = false; - for (s = 0; s < ARRAY_SIZE(d->st); s++) { - if (stnr == ((d->st[s].ctl >> 20) & 0x0f)) { - st = d->st + s; + st = output ? d->st + 4 : d->st; + for (s = 0; s < 4; s++) { + if (stnr == ((st[s].ctl >> 20) & 0x0f)) { + st = st + s; break; } } -- 1.7.4.4